Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve trophy pop-up #11078

Merged
merged 3 commits into from
Oct 30, 2021
Merged

Improve trophy pop-up #11078

merged 3 commits into from
Oct 30, 2021

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Oct 29, 2021

  • Fixes start and end positions of the trophy pop-up slide animation
  • Adds a fade in/out animation
  • Adds an optional sound-effect to the popup. It looks for the file "/sounds/trophy.wav"

Before:
ttropyhy

After:
ttropyhyac

@Zorklis
Copy link

Zorklis commented Oct 29, 2021

Could the fades be optional? Thanks

@Megamouse
Copy link
Contributor Author

No. that's stupid

@Megamouse
Copy link
Contributor Author

what I mean is: it's a lot of unnecessary work to add in more options just for a minor detail like this

@Megamouse
Copy link
Contributor Author

Added an optional sound-effect to the popup.
It tries to play the file "/sounds/trophy.wav"

@Megamouse Megamouse merged commit 0e20acd into RPCS3:master Oct 30, 2021
@Kilowog01
Copy link
Contributor

Kilowog01 commented Oct 30, 2021

I deleted my trophy save in LittleBigPlanet 2 and booted the game. Trophies appear again when savegame loads, but no pop-up sound. Not in the first one, or the last one.

@Megamouse
Copy link
Contributor Author

Did you put a .wav file into "/sounds/trophy.wav" as mentioned ?
if the folder doesn't exist in your rpcs3 directory then you have to create a new folder manually.

@Kilowog01
Copy link
Contributor

I thought your code would already do the extracting part of the .rco, added the sound now and it works, but this happens:
https://user-images.githubusercontent.com/16064499/139556787-ab3038f8-64be-4a61-baa6-fc616a1d99bf.mp4
My case is extreme, of course. But unlocking two or three trophies at the same time is not exactly difficult, it will certainly happen whenever someone gets a platinum trophy.

@Megamouse
Copy link
Contributor Author

lol. thx
I actually wanted to test it but I forgot. (I have a small piece of code that let's me spam those trophies)

@Megamouse
Copy link
Contributor Author

I fixed it. Should be in the next update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants